#19 create results layout #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
requested changes
Jan 28, 2021
|
|
||
| public onValChange(val: string) { | ||
| this.selectedVal = val; | ||
| this.store.dispatch(new EditResultView(val)); |
There was a problem hiding this comment.
name is not clear. Let use set prefix for setting values. e g SetCurrentView
| public selectedVal: string; | ||
|
|
||
| constructor(private store: Store) { | ||
| this.data$ = this.store.select(state => state.ShowData); |
There was a problem hiding this comment.
Not obvious what are you going to reach by selecting observable in one component and passing to another. Let's discuss tomorrow
src/app/shared/result.actions.ts
Outdated
| export class EditResultView { | ||
| static readonly type = '[Result] EditView'; | ||
| constructor(public payload: string) {} | ||
| } |
There was a problem hiding this comment.
suggestion to use the empty line at the end of each file for avoiding conflicts when somebody adds code to the file
dmitryy90
approved these changes
Feb 1, 2021
| @@ -0,0 +1,14 @@ | |||
| <mat-button-toggle-group #group="matButtonToggleGroup" [value]="currentView" (change)="SetCurrentView(group.value)"> | |||
| <mat-button-toggle value="show-data" aria-label="show-data"> | |||
There was a problem hiding this comment.
aria-label must be meaningful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.